Skip to content

refactor: Move some OS-specifics into tox_system. #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

refactor: Move some OS-specifics into tox_system. #2397

wants to merge 1 commit into from
+3,380 −1,425

Conversation

@iphydf
Copy link
Member

@iphydf iphydf commented Aug 29, 2023 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the v0.2.20 milestone Aug 29, 2023
@restyled-io restyled-io bot mentioned this pull request Aug 29, 2023
Closed
@iphydf iphydf force-pushed the system branch 11 times, most recently from a080382 to ee8b60e Compare August 30, 2023 14:25
@restyled-io restyled-io bot mentioned this pull request Aug 30, 2023
Closed
@iphydf iphydf force-pushed the system branch 3 times, most recently from 7b40cdf to 271bd9b Compare August 30, 2023 17:36
@restyled-io restyled-io bot mentioned this pull request Aug 30, 2023
Closed
@nurupo nurupo mentioned this pull request Aug 31, 2023
Merged
@iphydf iphydf force-pushed the system branch 5 times, most recently from 078fd55 to 3922dff Compare August 31, 2023 11:52
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.31844% with 203 lines in your changes are missing coverage. Please review.

Project coverage is 72.44%. Comparing base (102a1fa) to head (a3fc637).

❗ Current head a3fc637 differs from pull request most recent head 09f77d8. Consider uploading reports for the commit 09f77d8 to get more accurate results

Files Patch % Lines
toxcore/group_chats.c 74.24% 34 Missing ⚠️
toxcore/network_test_util.cc 0.00% 18 Missing ⚠️
toxcore/tox_system.c 0.00% 17 Missing ⚠️
testing/fuzzing/fuzz_support.cc 40.00% 12 Missing ⚠️
toxcore/os_network.c 79.31% 12 Missing ⚠️
toxcore/tox_network.c 52.00% 12 Missing ⚠️
toxcore/tox_log.c 0.00% 11 Missing ⚠️
toxcore/group_connection.c 83.33% 10 Missing ⚠️
toxcore/os_time.c 9.09% 10 Missing ⚠️
toxcore/tox.c 47.36% 10 Missing ⚠️
... and 17 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
- Coverage   73.08%   72.44%   -0.64%     
==========================================
  Files         149      162      +13     
  Lines       30531    30712     +181     
==========================================
- Hits        22313    22250      -63     
- Misses       8218     8462     +244

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf modified the milestones: v0.2.20, v0.2.19 Aug 31, 2023
@iphydf iphydf force-pushed the system branch 4 times, most recently from cc2950e to 1cb66a4 Compare January 18, 2025 23:12
@Green-Sky Green-Sky mentioned this pull request Jan 19, 2025
Open
@iphydf iphydf force-pushed the system branch 9 times, most recently from 54753a5 to 15f6cc3 Compare January 25, 2025 21:43
@iphydf iphydf marked this pull request as draft January 25, 2025 21:50
@iphydf iphydf force-pushed the system branch 12 times, most recently from 37fd7b2 to 80f8e1c Compare February 6, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactor Refactoring production code, eg. renaming a variable, not affecting semantics

Milestone

v0.2.22

Development

Successfully merging this pull request may close these issues.

1 participant

@iphydf